Hi,
I have two bugs to report when using this plugin on phpbb 3.1.6.
1. Redirection field is not working. It's not redirecting to page which I input.
2. After I log in on the forum using facebook for example, forum still looks like I'm logged out. If I navigate to other page from there, then it shows that I'm logged in.
I hope this can be fixed. I'm willing to provide more information if necessary.
Answers
after log in user still not logged, "reload" page not help.
after pressing some url ( index url for example) in browser i have url+?sid=sometext and logged user, after pressing some link again i have url in browser without sid and all work normal.
We will look into this.
But, we can't promise when unfortunately.
Regards.
Argh, this is an error.
We'll be updating the plugin shortly.
In the meantime, if you wish, you can edit a file to fix the redirect error:
In file: ext/oneall/sociallogin/acp/sociallogin_acp_module.php,
Line: 2305,
Replace: global $user, $phpbb_root_path, $phpEx;
With: global $user, $phpbb_root_path, $phpEx, $config;
Many apologies for this.
Thanks for reporting it!
For me, this was on line 2294. Unfortunately, this did not fix the problem.
Thanks.
You're right, in the current version, it is line 2294.
This should have corrected the redirect (when specified in the configuration for the extension).
Maybe you can purge the cache? (ACP initial page)
Regards.
Regards!
Sorry, did not understand your last post.
after log in user still not logged, "reload" (Ctrl+R in some browser) page not help.
after pressing some url ( index url for example) in browser i have url+?sid=sometext and logged user, after pressing some link again i have url in browser without sid and all work normal.
What is the URL to which you are setting the redirect?
Also, could you try something else?
In the same file: ext/oneall/sociallogin/acp/sociallogin_acp_module.php,
Line: 2316,
Replace:
redirect ($config ['oa_social_login_redirect'], false, true);
With:
redirect (append_sid ($config ['oa_social_login_redirect']), false, true);
Thanks.
Just for testing, I tried to redirect to page http://peugeotclub.ba/test, but nothing happens.
I'm still on the index page after login, and that index page looks like I'm not logged in until I click on some link in the forum.
P.S. I cleared the cache after this change.
Does this error occur when you choose a custom url to redirect to (in the extension settings)?
We do not really know what could be causing this. Maybe another extension is handling the redirection (core.functions.redirect event)?
but tapatalk settings not have any redirect options, and small question, how i can use tapatalk and one all together?
I am sorry that he did not think about the other extensions!
Best regards!
Good, thanks for checking this!
Tapatalk seems to interfere with redirects (from a brief look at their code: they listen to the mentioned redirect event).
There was one previous user who reported problems displaying Social Login icons on mobile with Tapatalk. So, we're not certain if both extensions would work.
Maybe you can identify if there is a way to configure Tapatalk's redirect options.
We may look into this, but we cannot promise much.
Regards
We will look at the Tapatalk/Social Login mix, and try to get them to work together for redirections initially.
Regards.
We cannot quite get the error reproduced with Tapatalk, yet.
However, could you possibly try this work-around (Sorry for the experimentation!):
In file: ext/tapatalk/tapatalk/event/main_listener.php
Change line 485: $data['return'] = true;
Into: $data['return'] = false;
This could impact the rest of Tapatalk (but hopefully should not).
Thanks.
And experimentation is not a problem, it's important that we solve the problem.
Parsing through the Tapatalk code, there was no obvious impact for this change.
We'll have another look, and perhaps submit this change to Tapatalk folks (the real fix would be to get rid of more code in Tapatalk, but this experiment was to prove the point in a least intrusive way).
Only the first fix ($config one) is required with custom redirects.
The other is a minor improvement.
We have both changes in the next Phpbb extension release (2.4.10), and already available from github repository.
Regards
We have sent you the updated zip file, as email attachment.
Could you possibly test it out with the Tapatalk extension?
Thanks.
Just an update to clarify the status: we have identified the cause for this error, and have a proposed fix in the OneAll plugin to work better with Tapatalk (without changes in Tapatalk).
As soon as this fix is further validated, we'll distribute it.
The small change to Tapatalk mentioned earlier in this post seems to work, but we'd rather avoid the risk of breaking Tapatalk.
Thanks to those involved with this for your help!